Skip to content

Fix variable names - #3344

Merged
1cg merged 2 commits into
bigskysoftware:masterfrom
szepeviktor:variable-fix
Jul 14, 2025
Merged

Fix variable names#3344
1cg merged 2 commits into
bigskysoftware:masterfrom
szepeviktor:variable-fix

Conversation

@szepeviktor

Copy link
Copy Markdown
Contributor

Description

Some variables names were misspelled.

@szepeviktor

Copy link
Copy Markdown
Contributor Author

Some test descriptions need a little care.

error: `retrives` should be `retrieves`
  --> -:2:21
  |
2 | 74 |   it('properly retrives shadow root host for extended selector', function() {
  |                     ^^^^^^^^
  |
error: `loction` should be `location`
  --> -:3:107
  |
3 | 60 |   it('preserved element should relocated unchanged if it is part of a oob swap targeting a different loction', function() {
  |                                                                                                           ^^^^^^^
  |
error: `preseved` should be `preserved`
  --> -:4:48
  |
4 | 72 |   it('when moveBefore is disabled/missing preseved content is copied into fragment instead of pantry', function() {
  |                                                ^^^^^^^^
  |
error: `backets` should be `baskets`, `brackets`, `buckets`
  --> -:5:63
  |
5 | 528 |   it('filters properly with condition containing square backets', function() {
  |                                                               ^^^^^^^
  |
error: `replacment` should be `replacement`
  --> -:6:61
  |
6 | 15 |   it('content of hx-history-elt is used during history replacment', function() {
  |                                                             ^^^^^^^^^^
  |
error: `cancled` should be `canceled`
  --> -:7:30
  |
7 | 25 |   it('hx-prompt that is cancled returns null and blocks the request', function() {
  |                              ^^^^^^^
  |
error: `retrives` should be `retrieves`
  --> -:8:21
  |
8 | 74 |   it('properly retrives shadow root host for extended selector', function() {
  |                     ^^^^^^^^
  |
error: `loction` should be `location`
  --> -:9:107
  |
9 | 60 |   it('preserved element should relocated unchanged if it is part of a oob swap targeting a different loction', function() {
  |                                                                                                           ^^^^^^^
  |
error: `preseved` should be `preserved`
  --> -:10:48
   |
10 | 72 |   it('when moveBefore is disabled/missing preseved content is copied into fragment instead of pantry', function() {
   |                                                ^^^^^^^^
   |
error: `backets` should be `baskets`, `brackets`, `buckets`
  --> -:11:63
   |
11 | 528 |   it('filters properly with condition containing square backets', function() {
   |                                                               ^^^^^^^
   |

@MichaelWest22 MichaelWest22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Many of these look to be things I've mistyped sorry

@MichaelWest22 MichaelWest22 added the ready for review Issues that are ready to be considered for merging label Jul 11, 2025
@1cg
1cg merged commit 9fb3c0e into bigskysoftware:master Jul 14, 2025
1 check passed
@szepeviktor
szepeviktor deleted the variable-fix branch July 15, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Issues that are ready to be considered for merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants