Skip to content

Conversation

@blister
Copy link

@blister blister commented Sep 9, 2025

Description

Code-comment mismatch for the default value of selfRequestsOnly config object option. It lists the default as false, but the actual default is defined as true.

Corresponding issue: #3428

Testing

Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@blister
Copy link
Author

blister commented Sep 9, 2025

I have absolutely no idea where those other 8 changed files are coming from.

image

Only thing I changed was that single line and was added to a brand new fork of the dev branch of this repo. Super weird.

@MichaelWest22
Copy link
Collaborator

You may have had an issue between master and dev branch. I would recommend pulling the latest dev branch again and re-doing your one line change. you can either use some git wizardry to force push this change into this branch to fix this PR but it may be easier to close this one and start a new one if you have issues.

@blister
Copy link
Author

blister commented Sep 15, 2025

Closed (replaced with: #3435)

@blister blister closed this Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants