Allow build commands to run under Windows #3488
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow running the build commands on Windows.
On Windows, even under WSL, it can't find
sedfrom within thepackage.jsonscripts.In addition, Windows doesn't have glob expansion, so instead it needs to get
brotli-clito do it.Due to line ending differences, the brotli versions of the non-minified JS files don't match exactly when generated on Windows. (Minification seems to auto-convert Windows line endings to Linux ones, but the brotlification doesn't.) I tried playing about with Git auto eol conversation config, but I didn't manage to win that battle.
Testing
I wiped out the contents of the dist folder, ran
npm run buildand then looked at the git diffs to see what changed.Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded