Skip to content

Conversation

@darkterror-jl
Copy link

add new option Strict for handling some cases, currently only covers take the value null as part of Binary Relational Expression.

I don't think return true for the expression ( null < 1 ) is make sense in some scenarios

The mainly thought is in Strict mode, we'll always get False when a side expression equals to null, we may could throw a specific exception instead of particular value

…s take the value `null` as part of Binary Relational Expression.

I don't think return `true` for the expression ( null < 1 ) is make sense in some scenarios

The mainly thought is in `Strict` mode, we'll always get `False` when a side expression equals to `null`,
we may could throw a specific exception instead of particular value
lu.jian added 2 commits March 22, 2023 00:33
Component:
Changes:
1. try to fix the code smell issue
Component:
Changes:
1. fix code smell issue
@bijington
Copy link
Owner

@darkterror-jl apologies for taking so long to take a look at this! I like the change and I am actually ok with proceeding with the breaking change. With this in mind I think we can avoid adding the new Strict option and just make this a change to the framework. We can just publish this in v3.0.0 to cover the breaking change. What do you think?

@darkterror-jl
Copy link
Author

@darkterror-jl apologies for taking so long to take a look at this! I like the change and I am actually ok with proceeding with the breaking change. With this in mind I think we can avoid adding the new Strict option and just make this a change to the framework. We can just publish this in v3.0.0 to cover the breaking change. What do you think?

Thank you for your reply and good to know that you like the changes, I'm totally ok with your decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants