Fixes for movement issues on Windows

Author: bijington

engine/Orbit.Input/GameControllers/GameControllerOptions.cs

@@ -8,5 +8,5 @@ public partial class GameControllerOptions
     /// <summary>
     /// Gets the threshold to use when comparing floats together in order to handle the inaccuracies that come with floats.
     /// </summary>
-    public float ComparisonThreshold { get; } = 5f;
+    public float ComparisonThreshold { get; set; } = 0.001f;
 }

engine/Orbit.Input/Platforms/Windows/GameControllerManager.cs

@@ -15,23 +15,10 @@ private GameControllerManager()
     public partial Task StartDiscovery()
     {
         Gamepad.GamepadAdded += OnGamepadAdded;
-        RawGameController.RawGameControllerAdded += OnRawGameControllerAdded;
 
         return Task.CompletedTask;
     }
 
-    private void OnRawGameControllerAdded(object? sender, RawGameController rawGameController)
-    {
-        var barry = new bool[rawGameController.ButtonCount];
-        var sarry = new GameControllerSwitchPosition[rawGameController.SwitchCount];
-        var aarry = new double[rawGameController.AxisCount];
-        rawGameController.GetCurrentReading(barry, sarry, aarry);
-
-        //var controller = new GameController(rawGameController);
-        //gameControllers.Add(controller);
-        //GameControllerConnected?.Invoke(this, new GameControllerConnectedEventArgs(controller));
-    }
-
     private void OnGamepadAdded(object? sender, Gamepad gamepad)
     {
         var controller = new GameController(gamepad);

games/Platformer/MainPage.xaml.cs

@@ -1,4 +1,6 @@
-using Orbit.Engine;
+using System.Diagnostics;
+
+using Orbit.Engine;
 using Orbit.Input;
 
 using Platformer.GameScenes;
@@ -102,14 +104,24 @@ private void GameControllerOnValueChanged(object? sender, GameControllerValueCha
 
         if (e.ButtonName == gameController.LeftStick.XAxis.Name)
         {
-            if (e.Value < 0.0000001f)
+            if (e.Value == 0)
+            {
+                this.playerStateManager.State = CharacterState.Idle;
+            }
+            else if (e.Value < -0.001f)
             {
                 this.playerStateManager.State = CharacterState.MovingLeft;
             }
-            else if (e.Value > 0.0000001f)
+            else if (e.Value > 0.001f)
             {
                 this.playerStateManager.State = CharacterState.MovingRight;
             }
+            else
+            {
+                this.playerStateManager.State = CharacterState.Idle;
+            }
+
+            Debug.WriteLine($"e.Value = {e.Value} {this.playerStateManager.State}");
         }
     }