Conversation
WIP - update form component to split date and time
mveytsman
requested changes
Aug 20, 2025
mveytsman
left a comment
Member
There was a problem hiding this comment.
This is fantastic!!
My one piece of feedback - I don't think this belongs in the Messaging context - in my mind that was about sending messages e.g. SMS or Slack...
I think delivery is too bloated - I want to say maybe a Notifications context.
What do you think? Or is that too confusing with Messaging and Notifications as different contexts?
Contributor
Author
a "Notifications" context makes sense! I will move that over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
CleanShot.2025-08-08.at.20.27.04.mp4
⏺ 📢 Add Banner System with Real-time Updates
Features
Useful for weather alerts, service updates, announcements, and urgent notices!