Skip to content

Add live views for banner feature. - #440

Merged
teesloane merged 17 commits into
mainfrom
ty/434
Aug 22, 2025
Merged

Add live views for banner feature.#440
teesloane merged 17 commits into
mainfrom
ty/434

Conversation

@teesloane

Copy link
Copy Markdown
Contributor

Describe your changes

CleanShot.2025-08-08.at.20.27.04.mp4

⏺ 📢 Add Banner System with Real-time Updates

Features

  • Banner management interface - Admin can create/edit/delete scheduled banners with date/time pickers
  • Time-based display logic - Only shows banners that are currently active (between start/end times and enabled)
  • Validation prevents invalid schedules - Can't create banners where start time is after end time
  • Real-time updates via PubSub - When banners are created/updated/deleted, all riders on /home see changes instantly
  • Prominent display on rider home page - Banners appear at top.
  • Multiple active banners supported - Shows all currently active banners simultaneously
  • Smart form with split date/time inputs - Follows campaign form pattern for better UX
  • Automatic expiration - Banners disappear when time window ends or when disabled
  • Query optimization - Efficient filtering by time range and enabled status
  • Comprehensive test coverage - Validation, CRUD, active filtering, real-time updates, and display integration

Useful for weather alerts, service updates, announcements, and urgent notices!

@teesloane
teesloane requested a review from mveytsman August 19, 2025 15:40

@mveytsman mveytsman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic!!

My one piece of feedback - I don't think this belongs in the Messaging context - in my mind that was about sending messages e.g. SMS or Slack...

I think delivery is too bloated - I want to say maybe a Notifications context.

What do you think? Or is that too confusing with Messaging and Notifications as different contexts?

@teesloane

Copy link
Copy Markdown
Contributor Author

What do you think? Or is that too confusing with Messaging and Notifications as different contexts?

a "Notifications" context makes sense! I will move that over.

@teesloane
teesloane requested a review from mveytsman August 21, 2025 16:29

@mveytsman mveytsman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@teesloane
teesloane merged commit e6b9b72 into main Aug 22, 2025
1 of 2 checks passed
@teesloane
teesloane deleted the ty/434 branch August 22, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants