Conversation
- Add /tags admin page for dispatchers to manage rider tags - Tags can be marked as restricted, hiding them from riders on their profile - Restricted tags are shown with a lock icon in the dispatcher view - Riders can only see and modify non-restricted tags on their profile - Remove inline tag creation from rider edit form (use Tags page instead) - Add Tags link to sidebar navigation
- Add tag fixture in test/support/fixtures.ex for creating test tags - Add context tests in riders_test.exs for tag CRUD operations: - create_tag, update_tag, delete_tag - list_tags, list_tags_with_rider_count - toggle_tag_restricted, change_tag, get_tag!, search_tags - Create tag_live_test.exs for Tags admin page: - List tags with name, restricted status, and rider count - Create, edit, delete tags via modals - Toggle restricted status inline - Access control for non-dispatchers - Add tag visibility tests in rider_live_test.exs: - Dispatcher can see all tags including restricted - Rider cannot see restricted tags on profile - Rider cannot see restricted tags in edit form
teesloane
approved these changes
Jan 28, 2026
teesloane
left a comment
teesloane
left a comment
Contributor
There was a problem hiding this comment.
Added a few optional nits and comments but can be merged without.
Comment on lines
+118
to
+127
| <span | ||
| class={[ | ||
| "my-0.5 inline-flex items-center px-2.5 py-1.5 rounded-md text-md font-medium cursor-pointer hover:bg-gray-200", | ||
| if(tag.restricted, do: "bg-gray-200 text-gray-500", else: "bg-gray-100 text-gray-500") | ||
| ]} | ||
| phx-click={JS.push("select", value: %{name: tag.name}, target: @myself)} | ||
| > | ||
| <Heroicons.plus mini class="w-4 h-4 mr-1" /> | ||
| {tag.name} | ||
| <Heroicons.lock_closed :if={tag.restricted} mini class="w-4 h-4 ml-1 text-amber-600" /> |
Contributor
There was a problem hiding this comment.
Not required but we could make this a "dumb component" to tidy up a bit.
| <.header> | ||
| Tags | ||
| <:subtitle> | ||
| Manage rider tags. Restricted tags are hidden from riders on their profile. |
Contributor
There was a problem hiding this comment.
Is it worth saying why one might want to add rider tags / how they are used?
| <% visible_tags = | ||
| if @current_user.is_dispatcher, | ||
| do: @rider.tags, | ||
| else: Enum.reject(@rider.tags, & &1.restricted) %> |
Contributor
There was a problem hiding this comment.
Opinion: normally I think it's fine to assign variables in template code, but since we're dealing with content that may be restricted, it might be worth pulling this out into a function and putting it in rider_live/show.ex
Member
Author
There was a problem hiding this comment.
FWIW this is still executed in the server (e.g. the security consideration doesn't apply here afaik, based on the liveview design) but I think it's correct for code quality
Co-authored-by: Ty <12987958+teesloane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Editing a riders' tags
When not a dispatcher you don't see restricted tags
Checklist before requesting a review
about this update in the description above.