ci: run GitHub release via semver postTarget#762
Merged
Conversation
Wire github back into version postTargets so {tag} and {notes} are
interpolated, enable semver push with noVerify, and use GITHUB_BOT_TOKEN
for gh release create during publishment.
Co-authored-by: Cursor <cursoragent@cursor.com>
Release preview
PR title: Semantic commit (PR title)✅ Valid conventional commit Version
Changelog preview## [9.2.1](https://github.com/bikecoders/ngx-deploy-npm/compare/ngx-deploy-npm-9.2.0...ngx-deploy-npm-9.2.1) (2026-05-31)Generated by CI (PR Release Preview). Actual release runs on merge via publishment.yml. Notes: Preview uses only the PR title (squash merge). Changes outside |
|
dianjuar
added a commit
that referenced
this pull request
Jun 2, 2026
fix(ci): use GIT_BOT_TOKEN for gh release auth in publishment PR #762 referenced a non-existent GITHUB_BOT_TOKEN secret, which left GITHUB_TOKEN empty during the semver github postTarget and broke release creation after npm publish. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
Publishment runs
npx nx github ngx-deploy-npmas a separate workflow step afterad-m/github-push-action. Thegithubtarget options use{tag}and{notes}, but those placeholders are only interpolated whengithubruns as aversionpostTarget. The standalone step passed literal{tag}togh release create, producing a broken release (e.g. tag name{tag}).Issue Number: N/A (follow-up to #761 / #244)
What is the new behavior?
githubback to theversionpostTargets withpush: trueandnoVerify: trueso semver interpolates{tag}/{notes}and runsgh release createduringnx version.GITHUB_BOT_TOKENasGITHUB_TOKENon the version step forgh.ad-m/github-push-actionafter tagginglast-releasefor force push of branch and tags to protectedmain.Does this PR introduce a breaking change?
Other information
GITHUB_BOT_TOKEN(fine-grained PAT) is configured with Contents: Read and write and the bot user is on themainbranch protection bypass list.GIT_BOT_TOKENremains used for checkout andad-m/github-push-action.Test plan
main(or dry-runnpx nx version ngx-deploy-npm --dry-runon a branch).ngx-deploy-npm-X.Y.Z) and changelog notes, not{tag}.mainstill succeed.