Open
Conversation
bingmann
force-pushed
the
master
branch
4 times, most recently
from
4ca77c7 to
fb05f21
Compare
Owner
|
Well, does not build on travis. |
bingmann
force-pushed
the
master
branch
8 times, most recently
from
dbd6db2 to
fb8a0d8
Compare
This works only for old compilers...
Author
|
Hi Timo, I pushed a quick fix. However, it will not work when compiled with more recent compilers that do not have experimental::filesystem. |
bingmann
force-pushed
the
master
branch
6 times, most recently
from
a92734e to
72365f5
Compare
leoisl
pushed a commit
to leoisl/cobs
that referenced
this pull request
Jul 1, 2022
…ndices (bingmann#6) Previously when combining multiple classic indices into a single classic index, the contents of source indices are read in as `char`. During the interleaving process, depending on the current position of the destination index, both left and right shifts on the next char could be performed. However, there are a few undefined behaviours that could affect the results depending on the platform: 1. The signedness of a `char` is an undefined behaviour. Hence when bit shifting, the usual arithmetic conversion performed on the char is undefined. The char could be promoted to either signed int or unsigned int. 2. If the char is treated as signed int, the bit shifting (both left and right) is also undefined in pre-c++20 standards. The behaviour is platform dependent. This change fixes the issue by declare the contents read from source indices as `unsigned char`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some minor changes to make it compilable with clang