Generalize shift verifier to be symbolic over Channel::Elem#1444
Merged
Conversation
The verifier should be single-threaded. Replace par_iter/reduce with sequential iter/fold in evaluate_matrices, which was the only function in the verifier using rayon.
Made some progress, shift check and ring-switching still remain.
Make evaluate_h_op, evaluate_matrices, and the shift_ind partial evaluation functions generic over E: FieldOps instead of F: Field. This allows check_eval to operate on symbolic channel element types like CircuitElem for the Spartan wrapper. Use the _scalars variants of eq_ind_partial_eval, lagrange_evals, evaluate_inplace, and inner_product throughout, replacing FieldBuffer with plain Vec/slice in the shift verifier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
evaluate_matrices(verifier should be single-threaded)verify_iopto operate symbolically overChannel::Elem, using_scalarsvariants of math functions and replacingFieldBufferwith plainVec/sliceTest plan