[frontend] Add message tweaking function#820
[frontend] Add message tweaking function#820paulcadman wants to merge 1 commit into08-20-_frontend_add_hash_chain_verificationfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
2a86a1d to
b59374d
Compare
b497b5d to
e0e55b4
Compare
b59374d to
fb9a470
Compare
e0e55b4 to
4564793
Compare
jadnohra
left a comment
There was a problem hiding this comment.
These requests are debatable, happy to discuss.
Function Names
- verify_chain_tweak() → compute_chain_hash()
- verify_message_tweak() → compute_message_hash()
- verify_chain() → verify_hash_chain()
- verify_tweaked_keccak() → compute_tweaked_hash()
Issue: "verify" prefix misleading - these build hash circuits, don't verify signatures
Variable Names
- coordinate → starting_position (clearer semantics)
- signature_chunk → signature_hash (it's a hash, not a chunk)
- param → domain_param (more specific)
- end_hash → public_key_element (describes role)
Module Structure
Current:
hash_based_sig/
├── chain.rs
└── tweak/chain.rs // name collision
Suggested:
hash_based_sig/
├── chain_verification.rs
└── hashing/
├── chain.rs
└── message.rs
4564793 to
db9c4d1
Compare
fb9a470 to
5f86282
Compare
db9c4d1 to
7fc6c27
Compare
5f86282 to
77b3d19
Compare
|
I've made the changes to the module structure and variable names that you suggested. For function names, I've changed to using the convention of adding a |
77b3d19 to
3e16df7
Compare
7fc6c27 to
c6feda2
Compare
Merge activity
|
This PR adds a Keccak256 tweak circuit that will be used to hash the messagfe in the hash-based signature scheme.
This PR adds a Keccak256 tweak circuit that will be used to hash the messagfe in the hash-based signature scheme.

This PR adds a Keccak256 tweak circuit that will be used to hash the messagfe in the hash-based signature scheme.