Closed
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd the label merge-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Contributor
Author
|
We have some kind of combinatoric blowup with the number of targets. To me it is a bit wasteful running all of them in CI. @fkondej Can we make some checks running only before the merge? |
GraDKh
force-pushed
the
dgordon/test_against_native_cpu_in_ci
branch
from
71ae714 to
1d0e717
Compare
GraDKh
changed the base branch from
graphite-base/886
to
dgordon/fix_x64_tests_with_gfni
graphite-app
bot
changed the base branch from
dgordon/fix_x64_tests_with_gfni
to
graphite-base/886
graphite-app
bot
force-pushed
the
dgordon/test_against_native_cpu_in_ci
branch
from
1d0e717 to
8fad546
Compare
graphite-app
bot
force-pushed
the
graphite-base/886
branch
from
380aa9b to
0b2ded1
Compare
graphite-app
bot
force-pushed
the
dgordon/test_against_native_cpu_in_ci
branch
from
8fad546 to
58b9fc7
Compare
pepyakin
reviewed
Sep 4, 2025
jadnohra
approved these changes
Sep 10, 2025
GraDKh
force-pushed
the
dgordon/test_against_native_cpu_in_ci
branch
from
58b9fc7 to
343d063
Compare
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dmytro Gordon.
|
GraDKh
force-pushed
the
dgordon/test_against_native_cpu_in_ci
branch
from
343d063 to
914e75c
Compare
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
### TL;DR Enable CPU-specific optimizations for test runs in CI by adding the `-C target-cpu=native` flag. Ideally we also need nightly jobs on `main` without those flags to ensure that portable version is not broken as well. ### What changed? Added the `-C target-cpu=native` rustflag to both the standard test and all-features test configurations in the CI workflow. This flag instructs the Rust compiler to generate code optimized for the specific CPU architecture of the machine running the tests. ### How to test? Run the CI pipeline and verify that tests complete successfully with the new flags. You can also compare performance metrics between runs with and without the flag to observe potential improvements. ### Why make this change? Using `-C target-cpu=native` allows the compiler to take advantage of all available CPU features on the CI machines, potentially improving test performance by generating more optimized code. This can lead to faster test execution without changing the actual test behavior or validity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Enable CPU-specific optimizations for test runs in CI by adding the
-C target-cpu=nativeflag.Ideally we also need nightly jobs on
mainwithout those flags to ensure that portable version is not broken as well.What changed?
Added the
-C target-cpu=nativerustflag to both the standard test and all-features test configurations in the CI workflow. This flag instructs the Rust compiler to generate code optimized for the specific CPU architecture of the machine running the tests.How to test?
Run the CI pipeline and verify that tests complete successfully with the new flags. You can also compare performance metrics between runs with and without the flag to observe potential improvements.
Why make this change?
Using
-C target-cpu=nativeallows the compiler to take advantage of all available CPU features on the CI machines, potentially improving test performance by generating more optimized code. This can lead to faster test execution without changing the actual test behavior or validity.