Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
| # Core dependencies for serialization | ||
| binius-core = { path = "../core" } | ||
| binius-utils = { path = "../utils" } | ||
| bytes = "1.7" |
There was a problem hiding this comment.
The dependency bytes = "1.7" violates workspace dependency management rules. All crate dependencies must reference workspace-wide declarations from the root Cargo.toml. Add bytes = "1.7" to the workspace dependencies section in the root Cargo.toml, then reference it here as bytes.workspace = true.
Spotted by Diamond (based on custom rule: Irreducible Rust and Cargo)
Is this helpful? React 👍 or 👎 to let us know.
| println!("cargo::rustc-check-cfg=cfg(has_binius_prover)"); | ||
| println!("cargo::rustc-check-cfg=cfg(no_binius_prover)"); |
There was a problem hiding this comment.
There's a syntax error in the cargo build script directives. The correct format uses a single colon rather than double colons:
println!("cargo:rustc-check-cfg=cfg(has_binius_prover)");
println!("cargo:rustc-check-cfg=cfg(no_binius_prover)");This needs to be fixed for the configuration flags to be properly recognized by Cargo during the build process.
| println!("cargo::rustc-check-cfg=cfg(has_binius_prover)"); | |
| println!("cargo::rustc-check-cfg=cfg(no_binius_prover)"); | |
| println!("cargo:rustc-check-cfg=cfg(has_binius_prover)"); | |
| println!("cargo:rustc-check-cfg=cfg(no_binius_prover)"); |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.

No description provided.