Skip to content

Add prover-interface#906

Closed
jadnohra wants to merge 1 commit intodgordon/add_verifierfrom
08-30-closed-source-prover-with-serial
Closed

Add prover-interface#906
jadnohra wants to merge 1 commit intodgordon/add_verifierfrom
08-30-closed-source-prover-with-serial

Conversation

@jadnohra
Copy link
Copy Markdown
Contributor

@jadnohra jadnohra commented Sep 1, 2025

No description provided.

Copy link
Copy Markdown
Contributor Author

jadnohra commented Sep 1, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jadnohra jadnohra mentioned this pull request Sep 1, 2025
# Core dependencies for serialization
binius-core = { path = "../core" }
binius-utils = { path = "../utils" }
bytes = "1.7"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency bytes = "1.7" violates workspace dependency management rules. All crate dependencies must reference workspace-wide declarations from the root Cargo.toml. Add bytes = "1.7" to the workspace dependencies section in the root Cargo.toml, then reference it here as bytes.workspace = true.

Spotted by Diamond (based on custom rule: Irreducible Rust and Cargo)

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Comment on lines +6 to +7
println!("cargo::rustc-check-cfg=cfg(has_binius_prover)");
println!("cargo::rustc-check-cfg=cfg(no_binius_prover)");
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a syntax error in the cargo build script directives. The correct format uses a single colon rather than double colons:

println!("cargo:rustc-check-cfg=cfg(has_binius_prover)");
println!("cargo:rustc-check-cfg=cfg(no_binius_prover)");

This needs to be fixed for the configuration flags to be properly recognized by Cargo during the build process.

Suggested change
println!("cargo::rustc-check-cfg=cfg(has_binius_prover)");
println!("cargo::rustc-check-cfg=cfg(no_binius_prover)");
println!("cargo:rustc-check-cfg=cfg(has_binius_prover)");
println!("cargo:rustc-check-cfg=cfg(no_binius_prover)");

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant