[Graphite MQ] Draft PR GROUP:spec_db2dd5 (PRs 887)#915
Closed
graphite-app[bot] wants to merge 1 commit intomainfrom
Closed
[Graphite MQ] Draft PR GROUP:spec_db2dd5 (PRs 887)#915graphite-app[bot] wants to merge 1 commit intomainfrom
graphite-app[bot] wants to merge 1 commit intomainfrom
Conversation
### TL;DR Remove the `Canonical` associated type from the `TowerField` trait and related code. This fixes the unit tests that were not passing with GFNI enabled because `is_canonical` was returning a wrong value ### What changed? - Removed the `Canonical` associated type from the `TowerField` trait - Removed implementations of this associated type from all implementors of `TowerField` - Removed the `is_canonical_tower` function and its usages - Removed the tower-to-AES and AES-to-tower mapping constants that were used for conversions - Removed the `linear_transform` function that was no longer needed - Simplified the `invert_or_zero` implementation to only handle AES tower fields without conversion ### How to test? - Run the existing test suite to ensure all functionality still works correctly - Verify that code using binary fields still compiles and functions as expected - Check that GFNI-based field operations still work correctly ### Why make this change? This change simplifies the binary field implementation by removing the concept of "canonical" tower fields. The code previously supported conversions between different representations of tower fields, but this added complexity wasn't necessary. By removing this abstraction, the code becomes more straightforward and easier to maintain while preserving all required functionality.
graphite-app
bot
deleted the
gtmq_spec_db2dd5_1756821824664-5fc70a88-2609-4863-b977-a0a76db8a1b7
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR was created by the Graphite merge queue.
Trunk will be fast forwarded to the HEAD of this PR when CI passes, and the original PRs will be closed.
The following PRs are included in this draft PR: