Hash-based signatures rust benchmarks#935
Conversation
How to use the Graphite Merge QueueAdd the label merge-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
|
||
| group.bench_with_input(BenchmarkId::from_parameter(&bench_name), &bench_name, |b, _| { | ||
| b.iter(|| { | ||
| let mut prover_transcript = ProverTranscript::new(StdChallenger::default()); |
There was a problem hiding this comment.
The Pseudo-Random Testing rule requires benchmarks to use rand::rng() instead of seeded RNGs. StdChallenger::default() likely uses a seeded RNG rather than thread RNG. Replace with rand::rng() for proper randomness in benchmarks, reserving StdRng::seed_from_u64 for reproducible tests only.
| let mut prover_transcript = ProverTranscript::new(StdChallenger::default()); | |
| let mut prover_transcript = ProverTranscript::new(StdChallenger::new(rand::thread_rng())); |
Spotted by Diamond (based on custom rule: Monbijou Testing Patterns)
Is this helpful? React 👍 or 👎 to let us know.
…benchmark Incorporated all improvements from hashsign-benchmarks including: - Centralized get_feature_suffix in PlatformDiagnostics - Parallel compression for improved merkle tree performance - Updated benchmark configurations (100ms warmup, 10s measurement, 10 samples) - Blake2s, keccak, and ethsign benchmarks set to 50 samples - Fixed tree height limit from 10 to 31 for realistic benchmarks - Default parameters: 4 validators, tree height 13, spec 2 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Replace bench_with_input with bench_function across all benchmarks (unused input param) - Set blake2s, keccak, ethsign to 50 samples for better statistical validity - Update default hashsign params: 4 validators, tree height 13, spec 2 - Fix overly restrictive tree height limit (10 → 31) to enable realistic benchmarks - Centralize get_feature_suffix() in PlatformDiagnostics to eliminate code duplication
2 participants
No description provided.