Skip to content

Update to Go 1.23 (and fix some nits) #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update to Go 1.23 (and fix some nits) #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/bio-rd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ func main() {

listenAddrsByVRF := map[string][]string{
vrf.DefaultVRFName: {
fmt.Sprintf(*bgpListenAddrIPv6),
fmt.Sprintf(*bgpListenAddrIPv4),
*bgpListenAddrIPv6,
*bgpListenAddrIPv4,
},
}

Expand Down
4 changes: 3 additions & 1 deletion fuzzing/packet/gen_initial_corpus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,13 @@ func main() {
wantFail: true,
},
}

for i, t := range tests {
f, err := os.Create(fmt.Sprintf("corpus/%v.bytes", i))
if err != nil {
log.Fatalf(err.Error())
log.Fatalf("%s", err.Error())
}

f.Write(t.input)
f.Close()
}
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ require (
google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 // indirect
)

go 1.18
go 1.23
2 changes: 1 addition & 1 deletion protocols/bgp/server/update_sender.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ func (u *UpdateSender) withdrawPrefix(out io.Writer, pfx *bnet.Prefix, p *route.
}

if !u.addressFamily.multiProtocol {
return fmt.Errorf(packet.AFIName(u.addressFamily.afi) + " was not negotiated")
return fmt.Errorf("%s was not negotiated", packet.AFIName(u.addressFamily.afi))
}

return u.withdrawPrefixMultiProtocol(out, pfx, p)
Expand Down
Loading