Skip to content

Support GHC-9.10 and GHC-9.12 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2025
Merged

Conversation

TeofilC
Copy link
Contributor

@TeofilC TeofilC commented Apr 9, 2025

No description provided.

@maksbotan
Copy link
Collaborator

I suppose for CI to pass Hackage index has to update, I'll merge this one tomorrow then.

@maksbotan
Copy link
Collaborator

Stupid cabal check...

Warning: [doc-place] Please consider moving the file 'CHANGELOG.md' from the
'extra-source-files' section of the .cabal file to the section
'extra-doc-files'.
These warnings may cause trouble when distributing the package:
Warning: [missing-upper-bounds] On library, these packages miss upper bounds:
- hspec
- QuickCheck
Please add them. There is more information at https://pvp.haskell.org/
Error: [missing-bounds-important] The dependency 'build-depends: base' does
not specify an upper bound on the version number. Each major release of the
'base' package changes the API in various ways and most packages will need
some changes to compile with it. The recommended practice is to specify an
upper bound on the version of the 'base' package. This ensures your package
will continue to build when a new major version of the 'base' package is
released. If you are not sure what upper bound to use then use the next major
version. For example if you have tested your package with 'base' version 4.5
and 4.6 then use 'build-depends: base >= 4.5 && < 4.7'.
Error: Hackage would reject this package.

@TeofilC I suppose we can add base <5 to build-depends?

@TeofilC
Copy link
Contributor Author

TeofilC commented May 18, 2025

I've added base<5 to the test suite components @maksbotan

Cabal check now succeeds locally

@maksbotan maksbotan merged commit 59b90df into biocad:master May 18, 2025
10 checks passed
@maksbotan
Copy link
Collaborator

Hackage done.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants