Skip to content

Windows compatibility - #1

Open
AliKhoda wants to merge 7 commits into
bioidiap:masterfrom
AliKhoda:master
Open

Windows compatibility#1
AliKhoda wants to merge 7 commits into
bioidiap:masterfrom
AliKhoda:master

Conversation

@AliKhoda

Copy link
Copy Markdown

Hi,

First efforts to make bob work on windows.

Thanks,
AKh

@183amir

183amir commented Jan 28, 2018

Copy link
Copy Markdown
Contributor

Hi Ali,

Instead of modifying all these places, you can just add this in construct_search_paths in utils.py to take CONDA_PREFIX\Library into account on Windoze.

@AliKhoda

Copy link
Copy Markdown
Author

Hi,

Thanks for the guidance. Changes are modified accordingly.

Comment thread bob/extension/utils.py
if os.name == 'nt':
binpaths += [os.path.join('mingw-w64','bin')]
name = name + '.exe'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to remove this too. We are trying to add support for msvc not mingw 64 which are incompatible

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think incompatibility applies to executables. Many executables are compiled on MingW and can be used by passing input arguments regardless of how they are compiled. Removing this will cause problems in the future, if not now. The "name = name + '.exe'" is also required as in windows executables need the extension in special cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants