Add sources and source record urls to align with TRAPI
#1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[EDIT] As part of the KGX+ handoff format work in Translator, we agreed that all node and edge properties should come from biolink-model. The format example uses TRAPI's
sourcesandsource_record_urlsproperties, which are missing from biolink-model. This PR adds them and makes minor adjustments to the existing RetrievalSource properties.References: TRAPI sources, source_record_urls and guide.
@sierra-moxon This PR currently...
doesn't addEDIT: added commit that does thissourcesto the Association class's slots. I wasn't sure whether to do this or not.retrieval source idssource web pageknowledge source,primary knowledge source,aggregator knowledge source,supporting data sourceslots