Fix shape mismatch error in gears caused by varying choose_binset#79
Open
OBJECT907 wants to merge 3 commits into
Open
Fix shape mismatch error in gears caused by varying choose_binset#79OBJECT907 wants to merge 3 commits into
OBJECT907 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
In the
gearsmodule, using differentbinset configurationsresults in a varying number of tokens. This causes a shape mismatch error when attempting to addpositional embeddings, as the sequence length exceeds or differs from the expected dimensions (positional embeddingsis always[num_genes, hidden_size])Fix:
I added a truncation operation to ensure the input sequence length aligns with the model's expectations. The code now explicitly slices the input to keep only the first
num_genestokens before addingpositional embeddings.