feat: support the new-style monorepo #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siketyan
commented
Jul 5, 2025
| @@ -0,0 +1 @@ | |||
| console.log('Hello, world!'); | |||
There was a problem hiding this comment.
This should be annotated with an error as noConsole is enabled in the root config.
| @@ -0,0 +1 @@ | |||
| console.log("Hello, world!"); | |||
There was a problem hiding this comment.
This should NOT be annotated as the rule is disabled in the nested config.
|
I think we can also close #161 as now we need to have only one LSP instance for the monorepo |
ematipico
approved these changes
Jul 5, 2025
| companion object { | ||
| @OptIn(ExperimentalSerializationApi::class) | ||
| fun loadFromFile(file: VirtualFile): BiomeConfig? { | ||
| val json = Json { ignoreUnknownKeys = true } |
There was a problem hiding this comment.
Does this support jsonc files too?
There was a problem hiding this comment.
Good catch! I added allowComments and allowTrailingComma flags to the Json() initializer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the monorepo structure, that is now supported since Biome v2.0, with the
root: falseandextends: //syntaxes.The plugin now skips the
biome.json(c)files withroot: falseorextends: //to ensure the workspace root to be where the root configuration exists.ref: https://biomejs.dev/guides/big-projects/#monorepo