-
-
Notifications
You must be signed in to change notification settings - Fork 578
fix: apply --skip-parse-errors
to lint, check and ci commands
#5780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
if ctx.execution.should_ignore_errors() && skipped_parse_error { | ||
// skip format to parse error files, a message for it already pushed by analyzer | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do nothing if already skipped parse error on the analyze phase.
I'm wondering if we should rename this flag. I introduced this option at the very beginning, when there was only a formatter. Now the meaning of "error" is different, and now there's a linter too. What do you think? |
Here’s the current description of --skip-errors:
Because the flag only deals with parse errors, how about renaming it to I’d also suggest making it a sub-command option rather than a global one. Commands like PS: rethink, we don't need to make it a specific options for them, I leave it as a global option. |
|
@ematipico Can we include the renaming to v2.0.0 release? (Assuming I make that change in this PR) |
Yes, that was the idea :) |
78ed2dd
to
62c5e23
Compare
CodSpeed Performance ReportMerging #5780 will not alter performanceComparing Summary
|
…nto use-skip-errors
--skip-errors
to lint, check and ci commands--skip-parse-errors
to lint, check and ci commands
Summary
Closes #3859
This PR applies the
--skip-parse-errors
option to below commands.biome lint
biome check
biome ci
biome format
is already applied the option.Since there is no need to display parse errors in analyze and format respectively, parse errors in format executed later are not output as messages (commented in code).
Test Plan
Added snapshot test