Skip to content

fix(useSortedClasses): recognize negative placement utilities #7408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

fix(useSortedClasses): recognize negative placement utilities #7408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion crates/biome_js_analyze/src/lint/nursery/use_sorted_classes/tailwind_preset.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use super::sort_config::UtilityLayer;

const COMPONENTS_LAYER_CLASSES: [&str; 1] = ["container$"];

const UTILITIES_LAYER_CLASSES: [&str; 578] = [
const UTILITIES_LAYER_CLASSES: [&str; 587] = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Edit the generator, not the generated file

This file is explicitly autogen. Please move the change into packages/@biomejs/tailwindcss-config-analyzer and re-run pnpm gen:tailwind-preset so the update is durable and won’t be clobbered on the next regen. Also run repo formatters before commit.

🏁 Script executed:

#!/bin/bash
set -euo pipefail
FILE=crates/biome_js_analyze/src/lint/nursery/use_sorted_classes/tailwind_preset.rs

# Sanity-check that all negative placement tokens are present
rg -n '"-inset-"|"-inset-x-"|"-inset-y-"|"-start-"|"-end-"|"-top-"|"-right-"|"-bottom-"|"-left-"' "$FILE"

# Regenerate from source and show any drift
pnpm -w gen:tailwind-preset
git --no-pager diff -- "$FILE" || true

# Optional: format
just f || just format || true

Length of output: 563

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Confirm file header to verify autogenerated notice
sed -n '1,20p' crates/biome_js_analyze/src/lint/nursery/use_sorted_classes/tailwind_preset.rs

# Locate the generator package directory
fd -t d tailwindcss-config-analyzer

# Check for gen:tailwind-preset script in root package.json
rg -n 'gen:tailwind-preset' package.json || echo "No root gen:tailwind-preset script found"

# Check for gen:tailwind-preset script in generator's package.json
if [ -f packages/@biomejs/tailwindcss-config-analyzer/package.json ]; then
  rg -n 'gen:tailwind-preset' packages/@biomejs/tailwindcss-config-analyzer/package.json || echo "No gen:tailwind-preset script in generator"
fi

Length of output: 954

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Verify the generator package exists and list its scripts
if [ -f packages/tailwindcss-config-analyzer/package.json ]; then
  echo "Found generator package.json at packages/tailwindcss-config-analyzer/package.json"
  rg -n '"gen:tailwind-preset"' packages/tailwindcss-config-analyzer/package.json || echo "gen:tailwind-preset script missing"
else
  echo "Generator package.json not found"
fi

Length of output: 416

Add missing gen:tailwind-preset script and regenerate Tailwind preset

The file crates/biome_js_analyze/src/lint/nursery/use_sorted_classes/tailwind_preset.rs is autogenerated—apply your change in packages/tailwindcss-config-analyzer, add a gen:tailwind-preset script to its package.json, run pnpm gen:tailwind-preset, commit the regenerated file, then run the repo’s formatters.

🤖 Prompt for AI Agents 
In
crates/biome_js_analyze/src/lint/nursery/use_sorted_classes/tailwind_preset.rs
around line 8, the autogenerated Tailwind preset file is out-of-date; you must
not edit this file directly. Instead, open packages/tailwindcss-config-analyzer,
add a "gen:tailwind-preset" script to its package.json that runs the generator
(e.g., node or pnpm command used by the package), run pnpm gen:tailwind-preset
to regenerate the preset, commit the updated tailwind_preset.rs into the crate,
and run the repository formatters (pnpm -w prettier/rustfmt or the repo-specific
format commands) before pushing.

"sr-only$",
"not-sr-only$",
"pointer-events-none$",
Expand All @@ -19,14 +19,23 @@ const UTILITIES_LAYER_CLASSES: [&str; 578] = [
"relative$",
"sticky$",
"inset-",
"-inset-",
"inset-x-",
"-inset-x-",
"inset-y-",
"-inset-y-",
"start-",
"-start-",
"end-",
"-end-",
"top-",
"-top-",
"right-",
"-right-",
"bottom-",
"-bottom-",
"left-",
"-left-",
"isolate$",
"isolation-auto$",
"z-",
Expand Down