fix(lint/useExhaustiveSwitchCases): improve type narrowing for default parameters #7545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect type inference where destructured parameters with default values were still considered to include undefined in their type union.
Fixes #7525
Summary
The
useExhaustiveSwitchCases
rule was incorrectly flagging switch statements as non-exhaustive when using destructured parameters with default values.Problem: When a parameter has a default value like
{ b = "thing" }: { b?: "thing" | "other" | "more" }
, thevariable
b
can never beundefined
because it has a default value. However, the rule was still requiring anundefined
case in switch statements.Solution: Added logic to detect when a discriminant variable comes from a destructured parameter with a default
value, and exclude
undefined
from exhaustiveness checking in those cases.Test Plan
invalidIssue7525.ts
with scenario of destructured parameters with defaultsundefined
casesDocs
No documentation changes needed - this is a bug fix that improves existing rule behavior.