refactor(markdown-parser): decompose handle_blank_lines into phase helpers#9453
refactor(markdown-parser): decompose handle_blank_lines into phase helpers#9453jfmcdowell wants to merge 1 commit intobiomejs:mainfrom
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA refactoring of blank-line handling in the markdown list parser that replaces a Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Note
AI Assistance Disclosure: This PR was developed with assistance from Claude Code.
Summary
Decompose
handle_blank_linesinto a named result type and five phase-specific helpers so the quote-aware blank-line state machine in list parsing is easier to audit without changing behavior.(LoopAction, bool)return type withBlankLineOutcome, makingline_has_quote_prefixexplicit at the call site.handle_blank_linesto a thin orchestrator over those phases.Test Plan
just test-crate biome_markdown_parserjust test-markdown-conformance(652/652, 100%)just fjust lDocs
N/A — internal parser refactor with no user-facing behavior change.