Add option for checking w3c specification on expand()#104
Open
cthoyt wants to merge 28 commits into
Open
Conversation
cthoyt
added a commit
that referenced
this pull request
Dec 19, 2024
This PR splits out some of #104 to implement regular expressions for testing prefix and CURIE validity against the W3C standard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #103.
This PR adds a
w3c_validationflag to instantiation of a converter and toConverter.expand()that turns on W3C CURIE specification validation. For now, it's not a "true" implementation of the W3C standard since this will take a huge amount of effort to implement and test (for, IMO, small returns), but it hits the main pain points Chris mentioned in #103 (specifically, the square bracket issue).This PR also begins developing a benchmarking suite of CURIEs (both valid and invalid)
Demo
This can be used when expanding a CURIE:
This can be used when instantiating a converter:
Caveats