Skip to content

Better support references without name slots #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cthoyt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Better support references without name slots #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/curies/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,9 +544,12 @@ def from_reference(cls, reference: Reference, *, converter: Converter | None = N
:param converter: The converter to use as context when parsing
:return: A reference object
"""
name = reference.name if isinstance(reference, NamableReference) else None
return cls.model_validate(
{"prefix": reference.prefix, "identifier": reference.identifier, "name": name},
{
"prefix": reference.prefix,
"identifier": reference.identifier,
"name": getattr(reference, "name", None),
},
context=converter,
)

Expand Down
Loading