Skip to content

Draft: Refactor ads::client::{Client, Source} && apply fixes to adstool to better handle edge cases #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

cartercanedy
Copy link

@cartercanedy cartercanedy commented May 28, 2025

The semantics of ads::Source::Auto and the documentation seemed unclear with respect to configurations where there is no local router and the client is connecting directly to the remote ADS server or the client is using a local router to connect to a remote machine.

This PR updates both the documentation and adds a new Source::Any variant (which behaves identically to Source::Auto) for the core library, and updates adstool route so that remote route management functions properly with more edge-cases.

note: this PR is stacked with #39, will rebase to get rid of the extra commits once it's merged

@cartercanedy cartercanedy changed the title Draft: Refactor of and update documentation for Client code && apply changes to make adstool route ... work for remote machines Draft: Refactor ads::client::{Client, Source} && apply fixes to adstool to better handle edge cases Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant