Draft: Refactor ads::client::{Client, Source} && apply fixes to adstool to better handle edge cases
#40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartercanedy
force-pushed
the
source-fixes
branch
from
09fa6db to
be6bc41
Compare
…lient configurations that don't have a local router available
cartercanedy
force-pushed
the
source-fixes
branch
from
be6bc41 to
0e25676
Compare
cartercanedy
changed the title
Client code && apply changes to make adstool route ... work for remote machinesads::client::{Client, Source} && apply fixes to adstool to better handle edge cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semantics of
ads::Source::Autoand the documentation seemed unclear with respect to configurations where there is no local router and the client is connecting directly to the remote ADS server or the client is using a local router to connect to a remote machine.This PR updates both the documentation and adds a new
Source::Anyvariant (which behaves identically toSource::Auto) for the core library, and updatesadstool routeso that remote route management functions properly with more edge-cases.note: this PR is stacked with #39, will rebase to get rid of the extra commits once it's merged