feat: default wallet to encrypted#135
Merged
ChrisSon15 merged 3 commits intobisq-network:mainfrom Mar 25, 2026
Merged
Conversation
ChrisSon15
reviewed
Mar 20, 2026
sdmg15
changed the title
ChrisSon15
reviewed
Mar 24, 2026
sdmg15
force-pushed
the
feat/encryption-granularity
branch
from
2bef46f to
e98858c
Compare
sdmg15
force-pushed
the
feat/encryption-granularity
branch
from
e98858c to
d576a3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The decryption is done on the active connection which holds the decryption key in memory.
Without setting the right
pragmavalue when connected to the database, an attacker will not be able to access the database.Even when the active connection has decrypted the file, on file system the database is still encrypted and can't be accessed. The decryption is done only to the active connection