Skip to content

update signTx flow using marina.sendTransaction (psetv2)#31

Open
louisinger wants to merge 9 commits intobit-matrix:masterfrom
louisinger:update-psetv2
Open

update signTx flow using marina.sendTransaction (psetv2)#31
louisinger wants to merge 9 commits intobit-matrix:masterfrom
louisinger:update-psetv2

Conversation

@louisinger
Copy link

@louisinger louisinger commented Feb 20, 2023

Note that the new provider now returns psetv2 only, it's possible that some changes are needed in bitmatrix-app-ui

TL;DR

  • remove ldk from pkg.json -> we'll drop support and use only liquidjs-lib (maybe the file "ldk.ts" should be renamed)
  • bump liquidjs-lib & remove resolutions in pkg.json
  • rework signTx function using marina.sendTransaction API (marina will handle blinding, coinselection and broadcasting)

PS:

  • Marina, Wallet and IWallet seem to be a bit redondant: hard to get the difference between all of them at first read in my opinion.
  • any reason to do not commit the yarn.lock file ? I would commit it to ensure we are on the same page while developing.

@tiero
Copy link
Contributor

tiero commented Apr 15, 2023

We may need to update to latest deps

@louisinger
Copy link
Author

UPDATE

last commit bumps marina-provider to 3.0.1 (latest). The only change is the importScript method (not needed so not implemented in Wallet interface.

@afarukcali please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants