update signTx flow using marina.sendTransaction (psetv2)#31
Open
louisinger wants to merge 9 commits intobit-matrix:masterfrom
Open
update signTx flow using marina.sendTransaction (psetv2)#31louisinger wants to merge 9 commits intobit-matrix:masterfrom
signTx flow using marina.sendTransaction (psetv2)#31louisinger wants to merge 9 commits intobit-matrix:masterfrom
Conversation
Contributor
|
We may need to update to latest deps |
louisinger
commented
May 24, 2023
Author
|
UPDATE last commit bumps @afarukcali please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the new provider now returns psetv2 only, it's possible that some changes are needed in bitmatrix-app-ui
TL;DR
ldkfrom pkg.json -> we'll drop support and use only liquidjs-lib (maybe the file "ldk.ts" should be renamed)liquidjs-lib& remove resolutions in pkg.jsonsignTxfunction usingmarina.sendTransactionAPI (marina will handle blinding, coinselection and broadcasting)PS:
Marina,WalletandIWalletseem to be a bit redondant: hard to get the difference between all of them at first read in my opinion.yarn.lockfile ? I would commit it to ensure we are on the same page while developing.