Skip to content

Added a is_actual_type to the type to differentiate type identificatio…#237

Merged
bitbrain merged 1 commit into
bitbrain:godot-4.xfrom
aarondamyen:Array-data-type-loading-fix
Jun 17, 2026
Merged

Added a is_actual_type to the type to differentiate type identificatio…#237
bitbrain merged 1 commit into
bitbrain:godot-4.xfrom
aarondamyen:Array-data-type-loading-fix

Conversation

@aarondamyen

@aarondamyen aarondamyen commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Description

Added a is_actual_type() to the type to differentiate type identification from the existing type conversion capability of is_valid(). When loading an Array, it's now using the is_actual_type in order to load the exact type it was saved as. Only the array loading is using this new function, any existing uses of is_valid() have not been changed.

Loading an array of Strings identifies each element as a Color because the is_valid() of the Color type recognizes the string content before the String type is queried. This is occuring because the is_valid() function doesn't just check for the exact type but also for any types it can convert from. Thus, other types, like references, also exhibit the same problem.

Note, this new function will also need to be added to custom data types created by users when extending the addon data types.

Addressed issues

Closes #210

Screenshots

No visible changes.

…n from the existing type conversion capability of is_valid(). When loading the data, now using the new type identification in order to load the exact type it was saved as.
@bitbrain bitbrain merged commit 08dd1c4 into bitbrain:godot-4.x Jun 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

String Array properties treated as Color type

2 participants