Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Fix terminal auto complete not properly handling folder casing #1929

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

CaseZumbrum
Copy link

closes #1708

Removed the conversion of paths to lowercase for the terminal auto completion. Previously, this would allow similarly named folders (scripts vs. Scripts) to share tab auto completion options.

Bug

Image showing improper casing, the "Scripts" folder does not exist but the terminal suggests files within the similar "scripts" folder.

fixed

Image showing proper casing, the "Scripts" folder does not exist, and no recommendations are given.

Tested with nested folders and ensured that auto completion still occurs on partial folder names (ex: typing "Scr" + TAB will autocomplete to "scripts")

@d0sboots
Copy link
Collaborator

The failing test indicates you broke some stuff. Code inspection also indicates (to me) that you broke cases like tab-completing Script/foo when Script is a directory that exists; I think you didn't test this well enough.

@d0sboots
Copy link
Collaborator

Let me level with you: I don't think this is a good first bug to tackle. It is one of those that looks like a small thing on the surface, but secretly it is an entire iceberg of complexity underneath.
I'm not sure what a correct fix to this bug would look like, but I know that I'd probably have to spend at least an hour working through the cases to figure it out. (And a similar amount of time to verify a potential fix.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal: tab auto-complete doesn't correct folder casing
2 participants