MISC: Add support for getting the save file through the RFA #2004
+51
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After some discussion on the discord, I think it's fair to say that importing a save via the RFA is not really desirable, especially loosing your progress due to unintentional imports. |
d0sboots
reviewed
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you can only programmatically get the save file through the NS API. While this does allow for automatic backups, getting those backups into your external editor can be quite cumbersome. Now, the current save file is exposed to the RFA via a new request.
I'm not quite sure if it should also be possible to import a save file via the RFA. It would be quite frustrating to have your save file be lost because your external editor overwrites it. Maybe a middle ground would be a confirmation popup? This feature seems quite niche IMO, so maybe it is not needed?