MISC: Warn player that they cannot accept Stanek's Gift after joining Bladeburner with SF7.3 #2005
+79
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A player reported a "bug" at https://steamcommunity.com/app/1812820/discussions/0/599646376816548634/. It's not a bug at all.
The Blade's Simulacrum
is shown in the "Augmentations" tab as normal. Having this free augmentation does not mean they can bypass the requirement of Stanek's Gift. Nonetheless, it's best if we warn the player about this behavior in both UI and TSDoc.Note: This code block is obsolete now:
I'm too lazy to search the git history for the specific commit, but I'm sure that we don't use "world-menu-header" anywhere in our current codebase. All code that calls
document.getElementById
is from the days in which we directly manipulated DOM instead of using React.Edit: The simpler way to deal with this issue is to whitelist "The Blade's Simulacrum" when checking the condition of accepting Stanek's Gift. However, there is no reason to make that augmentation an exception.