Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MISC: Warn player that they cannot accept Stanek's Gift after joining Bladeburner with SF7.3 #2005

Conversation

catloversg
Copy link
Contributor

@catloversg catloversg commented Mar 7, 2025

A player reported a "bug" at https://steamcommunity.com/app/1812820/discussions/0/599646376816548634/. It's not a bug at all. The Blade's Simulacrum is shown in the "Augmentations" tab as normal. Having this free augmentation does not mean they can bypass the requirement of Stanek's Gift. Nonetheless, it's best if we warn the player about this behavior in both UI and TSDoc.

Capture

Note: This code block is obsolete now:

const worldHeader = document.getElementById("world-menu-header");
if (worldHeader instanceof HTMLElement) {
  worldHeader.click();
  worldHeader.click();
}

I'm too lazy to search the git history for the specific commit, but I'm sure that we don't use "world-menu-header" anywhere in our current codebase. All code that calls document.getElementById is from the days in which we directly manipulated DOM instead of using React.

Edit: The simpler way to deal with this issue is to whitelist "The Blade's Simulacrum" when checking the condition of accepting Stanek's Gift. However, there is no reason to make that augmentation an exception.

@d0sboots d0sboots merged commit 8fe0ea1 into bitburner-official:dev Mar 7, 2025
6 checks passed
@catloversg catloversg deleted the pull-request/misc/warn-player-about-stanek-gift-and-sf-7.3 branch March 8, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants