REFACTOR: Move Result to the public API #2398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors Result<T> to be part of the public NetscriptDefinitions. It is not used by anything in this PR, but it is planned to be used in the autoinfil APIs, or lacking that, future APIs, so this should not be exposing anything prematurely.
Collaborator
|
It looks good to me. |
ficocelliguy
approved these changes
Nov 29, 2025
# Conflicts: # src/CotMG/Helper.tsx
Collaborator
|
I merged this PR to use |
Collaborator
Author
|
Ah right I forgot about this one after one of the checks failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors Result to be part of the public NetscriptDefinitions. It is not used by anything in this PR, but it is planned to be used in the autoinfil APIs, or lacking that, future APIs, so this should not be exposing anything prematurely.