Close console autocomplete when leaving Console tab - #809
Closed
uqlidi wants to merge 1 commit into
Closed
Conversation
Co-authored-by: johnny9 <johnny9dev@pm.me>
johnny9
approved these changes
Jul 22, 2026
hebasto
changed the title
jarolrod
approved these changes
Jul 23, 2026
hebasto
added a commit
that referenced
this pull request
Jul 23, 2026
5021838 qml: close console autocomplete when leaving Console tab (Uqlidi) Pull request description: The RPC console lives as a persistent StackLayout child and its autocomplete Popup renders in the window overlay layer, so hiding the console on a tab switch does not hide the popup. It lingers over the newly selected tab. Add a `tabActive` property to CommandConsole, bound by DesktopWallets to `consoleTabButton.checked`, and close the popup when the tab is left. Keyed off the tab ButtonGroup rather than StackLayout visibility, which never reports the transition. fix #782 ACKs for top commit: johnny9: ACK 5021838 jarolrod: ACK 5021838 Tree-SHA512: 884dbacc6653bc3e38c1bf157a8b58cd0091f5986c00eb2079670a81e44021e0f13721055cae02645ef376d85817c30e41680e9b0683ee91ffbfdea21bd5a188
Member
|
This PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RPC console lives as a persistent StackLayout child and its
autocomplete Popup renders in the window overlay layer, so hiding
the console on a tab switch does not hide the popup. It lingers over
the newly selected tab.
Add a
tabActiveproperty to CommandConsole, bound by DesktopWalletsto
consoleTabButton.checked, and close the popup when the tab isleft. Keyed off the tab ButtonGroup rather than StackLayout visibility,
which never reports the transition.
fix #782