Add dialog to select change output when bumping fee - #954
Add dialog to select change output when bumping fee#954pablomartin4btc wants to merge 4 commits into
Conversation
ConfirmSend and ConfirmMessage assumed that the widgets with the buttons to click would be ready by the time the functions fired. This may not necessarily be the case, so instead they should check for the right widgets in a loop and only exit when a button has been clicked.
In order to correctly choose the change output when doing fee bumping in the GUI, we need to ask the user which output is change. We can make a guess using our ScriptIsChange heuristic, however the user may have chosen to have a custom change address or have otherwise labeled their change address which makes our change detection fail. By asking the user when fee bumping, we can avoid adding additional change outputs that are unnecessary.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline and AI policy for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
🚧 At least one of the CI tasks failed. HintsTry to run the tests locally, according to the documentation. However, a CI failure may still
Leave a comment here, if you need help tracking down a confusing failure. |
3 participants
Rebases and fixes the closed #700.
Implements a GUI dialog that lets the user choose which output to use as change when bumping a transaction fee, bringing the GUI in line with the RPC functionality added in bitcoin/bitcoin#26467. Without this, the GUI adds an unnecessary extra change output when change detection fails (e.g. custom change addresses or labeled outputs).