ecdsa: VERIFY_CHECK result of _fe_set_b32_limit#1839
Open
real-or-random wants to merge 1 commit intobitcoin-core:masterfrom
Open
ecdsa: VERIFY_CHECK result of _fe_set_b32_limit#1839real-or-random wants to merge 1 commit intobitcoin-core:masterfrom
real-or-random wants to merge 1 commit intobitcoin-core:masterfrom
Conversation
This also avoids a spurious "-Wmaybe-uninitialized" warning emitted by gcc 16 (snapshot) when compiling with -DDETERMINISTIC.
|
Good solution. I find it more robust since it verifies the range assumption rather than just zero-initializing. I'll close my PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also avoids a spurious
-Wmaybe-uninitializedwarning emitted by gcc 16 (snapshot) when compiling with-DDETERMINISTIC.Alternative to #1838 by @mllwchrry who tried very a similar thing as this PR but couldn't convince the compiler. (The GCC snapshot is very annoying: a simple
VERIFY_CHECK(secp256k1_fe_set_b32_limit(&xr, c))doesn't do the trick. I found this variant here with a local store rather by accident.)