BIP348 OP_CHECKSIGFROMSTACK #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instagibbs
commented
Mar 13, 2025
instagibbs
force-pushed
the
2025-03-bip348-inq-28
branch
2 times, most recently
from
49b7873 to
8b70161
Compare
Implements script validation, but no exposure to any network as of yet.
instagibbs
force-pushed
the
2025-03-bip348-inq-28
branch
from
8b70161 to
c401fa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial resurrection of #45 , focused specifically on BIP348 spec adherence.
I kept the limited tests that pertained to OP_CHECKSIGFROMSTACK, but clearly it will need to cover the basic cases the BIP calls for.
If there's any intention to review this I can add the testing we think is appropriate, and activate on regtest/signet/whatever.