Implement BIP 118 validation (SIGHASH_ANYPREVOUT) #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajtowns
force-pushed
the
202507-inq29-apo
branch
from
64eb69a to
9befd65
Compare
ajtowns
force-pushed
the
202507-inq29-apo
branch
4 times, most recently
from
b5a61b9 to
e86b6d6
Compare
Introduce `KeyVersion` in preparation for defining new behaviours via BIP 342's "unknown public key type" upgrade mechanism.
… was conserved This fuzz targets copied the SignatureHashSchnorr function for Bitcoin Core 23.0 and checks the output of the APO-ready SignatureHashSchnorr from this branch against it. This is to make sure the behaviour of the function was not changed for non ANYPREVOUT keys, which would make some previously valid signatures invalid and, even worse, some previously invalid signatures valid.
ajtowns
force-pushed
the
202507-inq29-apo
branch
from
e86b6d6 to
c8d1936
Compare
arminsabouri
pushed a commit
to arminsabouri/bitcoin
that referenced
this pull request
Nov 30, 2025
c40dbbb test: Move `script_assets_tests` into its own suite (Hennadii Stepanov) Pull request description: This PR ensures that the `script_assets_tests` test case is explicitly reported as "Skipped" when it is not run, making it clearer when running the test suite with `ctest`: - on the master branch @ 9355578: ``` $ env -u DIR_UNIT_TEST_DATA ctest --test-dir build -j 16 -R "^script_" Internal ctest changing into directory: /home/hebasto/git/bitcoin/build Test project /home/hebasto/git/bitcoin/build Start 87: script_tests Start 83: script_p2sh_tests Start 85: script_segwit_tests Start 86: script_standard_tests Start 84: script_parse_tests 1/5 Test bitcoin-inquisition#84: script_parse_tests ............... Passed 0.11 sec 2/5 Test bitcoin-inquisition#86: script_standard_tests ............ Passed 0.11 sec 3/5 Test bitcoin-inquisition#85: script_segwit_tests .............. Passed 0.12 sec 4/5 Test bitcoin-inquisition#83: script_p2sh_tests ................ Passed 0.12 sec 5/5 Test bitcoin-inquisition#87: script_tests ..................... Passed 0.36 sec 100% tests passed, 0 tests failed out of 5 Total Test time (real) = 0.37 sec ``` - with this PR: ``` $ env -u DIR_UNIT_TEST_DATA ctest --test-dir build -j 16 -R "^script_" Internal ctest changing into directory: /home/hebasto/git/bitcoin/build Test project /home/hebasto/git/bitcoin/build Start 83: script_assets_tests Start 88: script_tests Start 84: script_p2sh_tests Start 86: script_segwit_tests Start 87: script_standard_tests Start 85: script_parse_tests 1/6 Test bitcoin-inquisition#85: script_parse_tests ............... Passed 0.11 sec 2/6 Test bitcoin-inquisition#83: script_assets_tests ..............***Skipped 0.12 sec 3/6 Test bitcoin-inquisition#86: script_segwit_tests .............. Passed 0.11 sec 4/6 Test bitcoin-inquisition#87: script_standard_tests ............ Passed 0.11 sec 5/6 Test bitcoin-inquisition#84: script_p2sh_tests ................ Passed 0.12 sec 6/6 Test bitcoin-inquisition#88: script_tests ..................... Passed 0.36 sec 100% tests passed, 0 tests failed out of 6 Total Test time (real) = 0.37 sec The following tests did not run: 83 - script_assets_tests (Skipped) $ env DIR_UNIT_TEST_DATA=/home/hebasto/git/bitcoin/qa-assets/unit_test_data ctest --test-dir build -j 16 -R "^script_" Internal ctest changing into directory: /home/hebasto/git/bitcoin/build Test project /home/hebasto/git/bitcoin/build Start 83: script_assets_tests Start 88: script_tests Start 84: script_p2sh_tests Start 86: script_segwit_tests Start 87: script_standard_tests Start 85: script_parse_tests 1/6 Test bitcoin-inquisition#85: script_parse_tests ............... Passed 0.11 sec 2/6 Test bitcoin-inquisition#87: script_standard_tests ............ Passed 0.11 sec 3/6 Test bitcoin-inquisition#86: script_segwit_tests .............. Passed 0.11 sec 4/6 Test bitcoin-inquisition#84: script_p2sh_tests ................ Passed 0.12 sec 5/6 Test bitcoin-inquisition#88: script_tests ..................... Passed 0.35 sec 6/6 Test bitcoin-inquisition#83: script_assets_tests .............. Passed 1.58 sec 100% tests passed, 0 tests failed out of 6 Total Test time (real) = 1.58 sec ``` ACKs for top commit: maflcko: re-ACK c40dbbb 👈 ajtowns: ACK c40dbbb achow101: ACK c40dbbb Tree-SHA512: 25713e1c3b507b6f2a5fecc7b1ea285a6642b906c248769238a58fc0df48489ac5f7606778f9e3653b407b7f1d06563e1554d04321303b350c80eb888500cc5d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port from #67