Mark Taproot BIPs as Final

[uncomputable]

Taproot is supported by Bitcoin Core and adopted by a majority of the network, so it should be marked as Final. The progression from Draft to Proposed and from Proposed to Final was likely forgotten.

[real-or-random]

ACK 43fa7cf

[jonasnick]

ACK 43fa7cf

[augustoproiete]

ACK 43fa7cf

[ajtowns]

Is Final meant to imply it won't change any more? If so, should merge/nack pending fixes like #1406 and #1329 first? Otherwise, if fixes of that nature are still okay, ACK.

[kallewoof]

I interpret 'final' as something that is adopted and in use, as opposed to a proposal, which is not yet (widely non-experimentally) used. So I think fixes post-final state are fine.

[luke-jr]

You forgot BIP 343, which was used to activate Taproot.

[uncomputable]

Thanks for pointing this out. I added a new commit. Not everyone seems to want to finalize BIP 343, so we can merge with or without it.

[jonasnick]

CC @michaelfolkson

[michaelfolkson]

CC @michaelfolkson

Personally I'm not bothered. I agree BIP 340-342 should be made Final. BIP 343 should also be made Final. Activation mechanism(s) seem to me to be entirely independent to the proposal(s) they are activating. I looked up SegWit activation BIPs and they were made Final in an independent pull request (#571) to the SegWit BIPs.

So happy to open an independent pull request to this one to make BIP 343 Final if that is what is blocking this.

[michaelfolkson]

ACK f4a05c1

Or alternatively remove the BIP 343 commit and merge #1426 instead. Either is fine with me.

[uncomputable]

Any opinions? Otherwise, let's merge it with BIP 343 included. We can squash the two commits to finalize all three BIPs at the same time, if that is an issue.