BIP draft: Raw() as subscript for descriptors #1721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
changed the title
furszy
force-pushed
the
2024_descriptors_raw_as_subscript
branch
2 times, most recently
from
634d18a to
47fed6d
Compare
sipa
reviewed
Dec 18, 2024
furszy
force-pushed
the
2024_descriptors_raw_as_subscript
branch
2 times, most recently
from
1b3ef5c to
a67af04
Compare
furszy
force-pushed
the
2024_descriptors_raw_as_subscript
branch
from
a67af04 to
9c59851
Compare
furszy
force-pushed
the
2024_descriptors_raw_as_subscript
branch
2 times, most recently
from
bf8415b to
88f6b2e
Compare
furszy
force-pushed
the
2024_descriptors_raw_as_subscript
branch
from
88f6b2e to
3197eb9
Compare
Not yet. Will do next year. |
Comment on lines
+36
to
+38
| there are other useful scenarios for this feature. For example, it allows representing | ||
| in a descriptor that we lack complete knowledge of all solvability paths but can still | ||
| solve the output. This includes cases like a taproot tree where we know only one of its |
There was a problem hiding this comment.
This is a bit unclear for me, can you clarify what do you mean by can still solve the output?
Comment on lines
+63
to
+64
| If a different version is required for any use case, a new BIP could introduce `raw(HEX, VERSION)` | ||
| in the future. |
There was a problem hiding this comment.
I think we should just support raw(HEX, VERSION) and be forward compatible which goes in line with what was suggested in the bitcoin/bitcoin#24114
murchandamus
added
the
PR Author action required
|
Concept ACK I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing arbitrary hex data to be wrapped in
sh(),wsh(), or even within theTREEargument of a
tr(KEY, TREE)descriptor enables the representation of currentlyinexpressible information.
Specifically, the absence of this feature limits the representation of non-standard redeem
and witness scripts. This occurs because they can currently only be represented as top-level
raw(HEX)descriptors, which retain only the output script information and lack the abilityto preserve the actual script.
This work stemmed from discussions with @sipa and @achow101 about the legacy
wallet migration path, particularly while investigating migrated descriptors that lacked
information about the script they were supposedly migrated from.
Additionally, issue #24114, specifically bitcoin/bitcoin#24114 (comment), provides
historical context and highlights other valid use cases enabled by this behavior change.