BIP-32: Minor grammar fixes #984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
Enegnei
added a commit
to Enegnei/This-Month-In-Bitcoin-Privacy
that referenced
this pull request
Aug 30, 2020
Related to: bitcoin/bips#984
schildbach
reviewed
Aug 31, 2020
| @@ -211,7 +211,7 @@ Private and public keys must be kept safe as usual. Leaking a private key means | |||
| Somewhat more care must be taken regarding extended keys, as these correspond to an entire (sub)tree of keys. | |||
|
|
|||
| One weakness that may not be immediately obvious, is that knowledge of a parent extended public key plus any non-hardened private key descending from it is equivalent to knowing the parent extended private key (and thus every private and public key descending from it). This means that extended public keys must be treated more carefully than regular public keys. | |||
| It is also the reason for the existence of hardened keys, and why they are used for the account level in the tree. This way, a leak of account-specific (or below) private key never risks compromising the master or other accounts. | |||
| It is also the reason for the existence of hardened keys, and why they are used for the account level in the tree. This way, a leak of account-specific (or below) private keys never risks compromising the master or other accounts. | |||
There was a problem hiding this comment.
If you switch "key" to the plural, shouldn't the "s" from "risks" be removed?
There was a problem hiding this comment.
No, I think "risks" would stay as it is, because it's the verb for the subject "leak," not "keys." If you remove what's in the middle of the sentence:
This way, a leak ... never risks compromising the master or other accounts.
|
@sipa This was changed after your last ACK... re-ACK? |
|
ACK, no alteration of meaning in the text AFAICT. Pinging @sipa for sign-off on the second commit. |
|
ACK 688b0da |
|
Thanks @sipa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very small grammar fix of "keys" to "key." I checked across all the currently open PRs related to BIP-32 (#293, #575, #576, #695, #785, #885), and I don't think any of them have suggested this change yet.