Skip to content

Conversation

@tvpeter
Copy link
Collaborator

@tvpeter tvpeter commented Jul 21, 2025

Description

fixes #194

Notes to the reviewers

  • enable offline signer for creating tx whenever hwi feature is enabled
  • make handle_offline_wallet_subcommand fn async to handle hwi operations
  • The display_address method in the provided trait in async-hwi library is meant to trigger address generation by the connected device and display it on the device screen. Generated addresses are the same for both the app and device, so app addresses are returned for the hwi address subcommand.

This feature was tested with SpecterSimulator and Coldcard, although not all hwi features were successfully tested on coldcard.

For signing with hwi, it does sign but do not finalized the PSBT, so it has to be finalized before broadcasting.

Changelog notice

Checklists

HWI Wallet Subcommands implementation

  • hwi devices
  • hwi register
  • hwi address
  • hwi sign tx

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@tvpeter tvpeter marked this pull request as ready for review July 23, 2025 04:34
@tvpeter tvpeter changed the title feat(hwi): add hwi device list wallet subcommand feat(hwi): add hardware wallet support Jul 23, 2025
@tvpeter tvpeter force-pushed the feat/hwi branch 2 times, most recently from 2c28a68 to 067f8eb Compare October 13, 2025 11:10
@coveralls
Copy link

coveralls commented Oct 13, 2025

Pull Request Test Coverage Report for Build 18523331619

Details

  • 0 of 182 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.2%) to 7.647%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils.rs 0 89 0.0%
src/handlers.rs 0 93 0.0%
Files with Coverage Reduction New Missed Lines %
src/handlers.rs 1 9.95%
Totals Coverage Status
Change from base Build 18520893551: -1.2%
Covered Lines: 105
Relevant Lines: 1373

💛 - Coveralls

@tvpeter tvpeter requested a review from notmandatory October 13, 2025 11:53
- enable offline signer for creating tx whenever
hwi feature is enabled
- make handle_offline_wallet_subcommand fn async
to handle hwi operations
- add connecting to hwi fn in utils
- add `register` wallet hwi subcommand
- add signing psbt with hardware wallet
- add ledger and coldcard integration
- update hwi as top level command
- update CHANGELOG

rebase and fix clippy issues
- async-hwi requires libudev-sys for linux systems
- remove skip_blocks param as it is no longer
needed for cbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Add back HWI signing support

2 participants