-
Notifications
You must be signed in to change notification settings - Fork 83
feat(hwi): add hardware wallet support #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tvpeter
wants to merge
6
commits into
bitcoindevkit:master
Choose a base branch
from
tvpeter:feat/hwi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c28a68 to
067f8eb
Compare
Pull Request Test Coverage Report for Build 18523331619Details
💛 - Coveralls |
- enable offline signer for creating tx whenever hwi feature is enabled - make handle_offline_wallet_subcommand fn async to handle hwi operations - add connecting to hwi fn in utils
- add `register` wallet hwi subcommand
fix clippy issues
- add signing psbt with hardware wallet
- add ledger and coldcard integration - update hwi as top level command - update CHANGELOG rebase and fix clippy issues
- async-hwi requires libudev-sys for linux systems - remove skip_blocks param as it is no longer needed for cbf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #194
Notes to the reviewers
display_addressmethod in the provided trait in async-hwi library is meant to trigger address generation by the connected device and display it on the device screen. Generated addresses are the same for both the app and device, so app addresses are returned for thehwi addresssubcommand.This feature was tested with
SpecterSimulatorandColdcard, although not allhwifeatures were successfully tested on coldcard.For signing with hwi, it does sign but do not finalized the
PSBT, so it has to be finalized before broadcasting.Changelog notice
Checklists
HWI Wallet Subcommands implementation
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.mdBugfixes: