-
Notifications
You must be signed in to change notification settings - Fork 83
doc: added prerequisites to readme #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion that will be helpful to new devs who haven't already installed gcc.
README.md
Outdated
| #### Prerequisites | ||
|
|
||
| Building BDK requires gcc. If you do not have this installed run: | ||
| ```` shell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛏️ needs to be three back-ticks and no space after.
| ```` shell | |
| ```shell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sub-section should also be placed at the beginning of the "Install bdk-cli" section.
Pull Request Test Coverage Report for Build 18167582568Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 20305fb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @RockRockX2, I left a suggestion for you to check.
| Building BDK requires gcc. If you do not have this installed run: | ||
| ``` shell | ||
| sudo apt-get install build-essential | ||
| ```` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be three back-ticks to close the code block.
added gcc as a prerequisite.