Skip to content

Conversation

@RockRockX2
Copy link

added gcc as a prerequisite.

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion that will be helpful to new devs who haven't already installed gcc.

README.md Outdated
#### Prerequisites

Building BDK requires gcc. If you do not have this installed run:
```` shell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ needs to be three back-ticks and no space after.

Suggested change
```` shell
```shell

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sub-section should also be placed at the beginning of the "Install bdk-cli" section.

@notmandatory notmandatory moved this to Ready to Review in BDK-CLI Sep 30, 2025
@coveralls
Copy link

coveralls commented Sep 30, 2025

Pull Request Test Coverage Report for Build 18167582568

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 8.628%

Totals Coverage Status
Change from base Build 17621040142: 0.0%
Covered Lines: 105
Relevant Lines: 1217

💛 - Coveralls

Copy link
Collaborator

@tvpeter tvpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 20305fb

Copy link

@aagbotemi aagbotemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @RockRockX2, I left a suggestion for you to check.

Building BDK requires gcc. If you do not have this installed run:
``` shell
sudo apt-get install build-essential
````
Copy link

@aagbotemi aagbotemi Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be three back-ticks to close the code block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready to Review

Development

Successfully merging this pull request may close these issues.

5 participants