Added validate_domain in electrum option #223
Open
+35
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rahamath-unnisa pls mention in PR description that this resolves #134. |
110CodingP
reviewed
Oct 21, 2025
src/commands.rs
Outdated
| #![allow(clippy::large_enum_variant)] | ||
|
|
||
| #[allow(clippy::large_enum_variant)] |
There was a problem hiding this comment.
ig this is not required.
110CodingP
reviewed
Oct 21, 2025
src/handlers.rs
Outdated
| //! | ||
| //! This module describes all the command handling logic used by bdk-cli. | ||
| use crate::debug; |
There was a problem hiding this comment.
ig this is not needed either.
110CodingP
suggested changes
Oct 21, 2025
| }, | ||
| /// Syncs with the chosen blockchain server. | ||
| Sync, | ||
| /// Broadcasts a transaction to the network. Takes either a raw transaction or a PSBT to extract. |
There was a problem hiding this comment.
This doc comment should not be removed.
src/handlers.rs
Outdated
| .populate_tx_cache(wallet.tx_graph().full_txs().map(|tx_node| tx_node.tx)); | ||
|
|
||
| let update = client.sync(request, batch_size, false)?; | ||
| let update = client.sync(request, batch_size, validate_domain)?; |
|
Hi @110CodingP, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the validate_domain option to the Electrum client in bdk-cli.
This resolves #134 .
Changes included:
Added --validate-domain flag in command.rs.
Updated Electrum client handling in handlers.rs and utils.rs to respect the flag.
Verified functionality locally using:
RUST_LOG=debug,rusqlite=info,rustls=info cargo run --features electrum -- wallet --client-type electrum --database-type sqlite --url ssl://electrum.blockstream.info:60002 --validate-domain true --ext-descriptor "wpkh(.../*)" sync
Motivation:
Allows users to enable or disable domain validation for Electrum servers, useful for self-hosted/custom servers while preserving security by default.
Checklist:
Tested locally with Electrum client
No unrelated changes included