Use TxIn type from bitcoin-ffi
#610
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
force-pushed
the
refactor/txin
branch
3 times, most recently
from
a77f9e8 to
cd75c64
Compare
thunderbiscuit
force-pushed
the
refactor/txin
branch
from
cd75c64 to
353932f
Compare
|
Reviewing bitcoindevkit/bitcoin-ffi#29 and having this merged into bdk-ffi to use the bitcoin-ffi I see you'll have to fix conflicts, but bitcoindevkit/bitcoin-ffi#25 has been merged in so that's not a blocker anymore at least it looks like |
|
This is not required anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed our
TxInin favour of the bitcoin-ffi one. Note that bitcoindevkit/bitcoin-ffi#25 must be merged first, and this commit updated to use an official release of the library instead of the commit of the PR. Do not merge until bitcoin-ffi 0.1.3 is released.Changelog notice
None.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing