Ci/apply zizmor security audit #720
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aagbotemi
force-pushed
the
ci/apply-zizmor-security-audit
branch
2 times, most recently
from
47289f4 to
806a520
Compare
aagbotemi
force-pushed
the
ci/apply-zizmor-security-audit
branch
from
806a520 to
903e6bc
Compare
|
This PR has been signed and rebased. Similar fix has been done in bdk. Thanks. |
ItoroD
reviewed
Apr 15, 2025
|
Just a quick update: I'll wait for bitcoindevkit/bdk_wallet#8 to get merged before looking at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #638. It fixes persist credentials and template injection (environment variable was used).
Notes to the reviewers
Changelog notice
Checklists
All Submissions: