Skip to content

Use Txid, BlockHash, DescriptorId, and TxMerkleNode where applicable #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use Txid, BlockHash, DescriptorId, and TxMerkleNode where applicable #764

wants to merge 1 commit into from
+55 −55

Conversation

rustaceanrob
Copy link
Collaborator

Explicitly leaving out BlockId to avoid merge conflicts. The refactor here is moslty uneventful, however it removes a handful of unwrap when parsing transaction IDs.

Changelog notice

  • Use new hash types across public APIs

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@rustaceanrob rustaceanrob changed the title Use Txid and BlockHash where applicable Use Txid, BlockHash, DescriptorId, and TxMerkleNode where applicable May 14, 2025
@rustaceanrob
refactor: use Txid, BlockHash, DescriptorId, TxMerkleNode whe…
0d80e13 
…re applicable

Explicitly leaving out `BlockId` to avoid merge conflicts. The refactor
here is moslty uneventful, however it removes a handful of `unwrap` when
parsing transaction IDs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rustaceanrob