Skip to content

tests(swift): debug info #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

tests(swift): debug info #765

merged 1 commit into from
May 15, 2025

Conversation

reez
Copy link
Collaborator

@reez reez commented May 14, 2025

Description

Getting intermittent failures like this on live tests on CI.

Can't reproduce locally, so trying to get more output to debug with.

The fflush function should force the standard output buffer to be written, so our diagnostic messages are more likely to appear in the CI logs even if the test subsequently crashes or encounters an assertion failure.

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez requested a review from thunderbiscuit May 14, 2025 20:39
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0a756b6.

@reez reez merged commit 0a756b6 into bitcoindevkit:master May 15, 2025
1 check passed
@reez reez deleted the flush branch May 15, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants